Repository navigation
fix(steward): tolerate report validator python upgrades and prevent session queue monitor kills - #9155
Conversation
…vent queue kill on observation monitors Signed-off-by: LoopX Agent <[email protected]>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent | model: Gemini | provider: Google | declaration_source: self_reported
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
本次基于当前精确提交 c388daafd459d49fd12cfdc9f983a6f3711667fc 对 PR #9155 完成全量 diff 与本地验证复审:结论为通过(作者本人 PR 由受保护的 COMMENTED 结论替代 GitHub APPROVE)。
动机 / Motivation
受管对话定时汇报与持续监控的维护者在本地版本升级或上游模型传输短暂不可用后,会遇到两类阻断恢复的问题。此前在原报告恢复与观测型监控队列调度链路中,一旦跨版本升级更换了 Python 解释器路径,或者观测型 monitor 在队列唤醒期间撞上模型适配器准备失败,就会出现整个窗口与监控长期卡死且每日轮询空转失败的后果。本次修改通过统一报告校验命令的白名单等价比较、跳过无模型观测监控的模型适配器检查以及为过上下文零副作用重启载体增加 300 秒冷却链式恢复,使报告恢复与监控自愈可以安全继续推进,同时明确不改变非报告请求校验语义、不扩大权限边界,也不调整报告内容结构与投递规则。
改动思路 / Approach
针对报告升级卡死、队列误杀无模型监控和重启载体永久锁死三个问题,本 PR 选择在现有控制面和传输所有权边界内做最小必要修补,保留已有的单次权威约束,仅在可验证安全的路径放行恢复,当前 PR 边界清晰可控且无需额外抽象。
| 方案维度 | 不做改动 / 仅靠人工干预 | 过宽放行 validation_command 或取消队列检查 |
当前方案(既有所有者内精确收口) |
|---|---|---|---|
| 报告恢复稳定性 | 跨版本升级后 .admission-resume 等持续报错卡死 |
若放开任意命令比较会引入命令注入或跨目录校验漂移 | 仅允许 _REPORT_VALIDATOR_PREFIX 且同路径 -c 参数下的解释器路径差异 |
| 观测型监控安全性 | 队列并发唤醒可能触发 _ensure_adapter 并误杀活跃 monitor |
若全面跳过 _ensure_adapter 会破坏普通模型 Turn 恢复 |
仅对 loopx_execution=True 且 work_kind=="monitor" 跳过并复用 StewardObservationAdapter |
| 重启载体恢复策略 | .restart-recovery 遇短暂传输失败即永久停滞 |
若无冷却立即无限链式重试会饿死同级其他到期监控 | 要求 300s 冷却与单上下文零副作用证据,同时保持 scope/identity 拒绝仅单次 |
具体改动 / Changes
无单独书面 RFC 规格:本次改动针对运行期边界与队列竞争缺陷,共涉及 3 个生产模块和 4 个测试文件(总计 +514 / -36 行)。
关键代码讲解
sameReportValidatorCommand/admitReportSelectionRecovery/admitReportQuotaRecovery/admitStewardManagedTurn(steward_managed_mode.ts):在 TypeScript 准入层实现与 Python 端_same_report_validator_command对齐的白名单等价函数,仅当命令为 3 元非空无\0字符串、第二项为-c且第三项完全一致地以REPORT_VALIDATOR_PREFIX开头、"))"结尾时容忍首个可执行路径变化;同时将其一致应用到 selection recovery(原请求及 probe Turn)、quota recovery 和 launch recovery 的对比中,并配合steward_turn.py在构造.quota-recovery时刷新validation_command。admitMonitorRestartRecovery与monitor_restart_request(steward_managed_mode.ts、steward_turn.py):由monitor_restart_basis传递观测时间observed_at,TypeScript 准入端与 Pythonmonitor_restart_request共同强制observed_at - completed_at >= 300s的冷却时间以及单一manager_turn_context_v1+poll_absent+upstream_turn_id === null证据,方才允许 post-context 零副作用瞬态失败载体(runtime_unavailable、信号源不可用、磁盘 I/O 或 worker 退出)发起.restart-recovery.<carrier_turn_id>恢复;而scopeRefused、identityRefused与缺失时间戳场景仍保持严格拒绝。_is_observation_only_monitor_turn与_drain_session_queue_events(session_queue.py):精准识别loopx_execution is True且work_kind == "monitor"的原生无模型监控 Turn;在活跃 Turn 检查分支跳过不必要的模型适配器健康检查与_ensure_adapter调用(防止模型传输不可用时调用_fail_queue_preparation误杀正在采集上下文的监控),并在恢复崩溃遗留的 queued monitor 时直接注入StewardObservationAdapter。
对主干的风险 / Risks
- 边界与反例控制:通过负向用例验证了目标文件夹路径变化、
-c改成-m、非报告 Turn 混用、冷却不足(<300s)、缺少observed_at/completed_at,以及scopeRefused/identityRefused的链式重试均保持PASS拒绝(Fail-closed);普通模型 Turn 仍走原有_ensure_adapter与_fail_queue_preparation路径,默认隔离保持不变。 - 语义与词表:未引入或扩展任何共享协议状态枚举,全部校验和冷却常量均局限于现有
steward_managed_mode/steward_turn/session_queue所有者内部。 - 本地验证实况:
node --experimental-strip-types --test tests/control_plane_ts/steward_managed_mode.test.ts tests/control_plane_ts/steward_reports.test.ts26/26 PASS;ruff checkPASS;tests/test_steward_report_recovery_and_validator.py5/5 PASS;tests/test_native_steward_monitor.py176/176 PASS;tests/test_chat_queue_preparation.py44/44 PASS(含并发负载复测[always-False-thread/start-1]单独重跑通过);loopx canary premerge --from-git-diff --git-diff-base origin/main --tier quick3/3 canaries + 6 direct checks 全部 PASS,公开边界扫描PUBLIC_BOUNDARY_CLEAN。
我的整体评价 / Verdict
综合来看,该 PR 精准定位并根治了本地版本升级和瞬态传输中断下的管家定时汇报与监控卡死问题,长程稳健性与用户体验明显改善(improved / improved),且代码体量收敛(necessary)、所有权划分清楚、前后兼容性保持完好、默认无副作用隔离完整。当前改动不改变报告渲染 UI,无可视化页面差异需要额外核验(未涉及页面交互或视觉回归边界,无需额外截图检查)。所有新增常量与状态约束均为局部复核逻辑,未改动公开词汇注册表或跨项目契约。
English verdict: APPROVE — Exact head c388daafd459d49fd12cfdc9f983a6f3711667fc safely aligns TypeScript and Python report validator path portability, shields active and crash-queued observation-only monitor turns from model adapter preparation failures in session_queue.py, and unblocks post-context transient monitor recovery carriers with a verified 300s cooldown; all targeted TS/Python unit suites, ruff, and canary premerge checks passed locally without blockers.
* fix(cli): preserve typed runtime diagnostics in Turn failures Signed-off-by: LoopX Agent <[email protected]> * feat(steward): support per-endpoint model preferences and Codex-to-Antigravity failover (#9141) Signed-off-by: LoopX Agent <[email protected]> * Keep the prepared Chat adapter available to a retry (#9134) A failed worker start can finish cleanup after a same-turn retry has selected the adapter. Keep its lifetime tied to the Session and let failed dispatch release its own worker registration. The regression asserts one upstream turn and explicit adapter closure with the Session. Port the fix from 4453e4bdd77486ec14b952f88ca893310b32e26c. (cherry picked from commit 173e42b4f051b885c3a3389e1cad9c5722f7b7dd) Signed-off-by: LoopX Agent <[email protected]> * fix(steward): recover zero-effect monitors and cleared-replan reports (#9143) Signed-off-by: LoopX Agent <[email protected]> * fix(steward): admit flexible_primary_available executor transitions in conversation_scope (#9145) Signed-off-by: LoopX Agent <[email protected]> * Verify quota gate scope through signed lane references (#9101) * test(quota): verify scoped gates through complete lane references Signed-off-by: LoopX Agent <[email protected]> * Test canonical quota gates in both public response modes Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * Test C1 planning and Host input from the original quota capture (#9102) * Use recorded quota decisions in the no-Todo settlement regression Signed-off-by: LoopX Agent <[email protected]> * Exercise the complete Host prompt from the captured quota source Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * Prepare the CLI budget baseline with a private Git index (#9103) Signed-off-by: LoopX Agent <[email protected]> * Exercise C1 Goal delivery and bound replan from the saved source (#9104) Signed-off-by: LoopX Agent <[email protected]> * Keep long claim overlap scopes on demand (#9086) * Link long thin-claim overlap lists to their receipts Signed-off-by: LoopX Agent <[email protected]> * Read claim overlap details without copying the lease Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(quota): preserve explicit Monitor Todo selection (#9099) Carry Todo selection provenance into quota admission. Preserve explicit secondary Monitor polling and recovery from previously admitted receipts. Signed-off-by: LoopX Agent <[email protected]> * Keep ready Todo scope details on the required context read (#9106) Signed-off-by: LoopX Agent <[email protected]> * Fix archive rollback with custom install directories (#9066) * refactor(core): defer benchmark implementations during capability discovery Preserve the benchmark toolkit public exports and static types while keeping execution and experiment implementations out of metadata discovery. Qualify source and installed Core paths, and reconcile the paired minimal/Standard RFC boundary without changing activation or authority defaults. Signed-off-by: cicolord <[email protected]> * Defer Yardstick evaluation until an enabled Explore read Signed-off-by: cicolord <[email protected]> * Omit empty Todo summary lanes from ordinary Worker context Signed-off-by: cicolord <[email protected]> * fix(update): honor configured archive directories during rollback Signed-off-by: LoopX Agent <[email protected]> * fix(lark): replay recall guard on current main Signed-off-by: huangruiteng <[email protected]> * docs: record the verified LoopX 2.3.0 release baseline Signed-off-by: LoopX Agent <[email protected]> * Preserve quota spend source when prepared work is admitted Signed-off-by: LoopX Agent <[email protected]> * test(quota): qualify native saved complete-Turn checkpoints Signed-off-by: LoopX Agent <[email protected]> * Retry cleanup of an owned file mutation marker Signed-off-by: LoopX Agent <[email protected]> * Keep synthetic Git-path test data outside the public source scan Signed-off-by: LoopX Agent <[email protected]> * fix(quota): share native preparation wait with readiness Signed-off-by: LoopX Agent <[email protected]> * fix(doctor): bind package update readback to its Python environment Signed-off-by: LoopX Agent <[email protected]> * Keep Doctor discovery separate from service activation Signed-off-by: LoopX Agent <[email protected]> * Verify the recorded Python launcher before Doctor probes it Signed-off-by: LoopX Agent <[email protected]> * fix(desktop): require runtime qualification for macOS preview updates Signed-off-by: LoopX Agent <[email protected]> * fix(quota): reuse replan projection owners during recovery Signed-off-by: LoopX Agent <[email protected]> * Qualify Codex 0.169 native context replay on main Signed-off-by: LoopX Agent <[email protected]> * Stop regenerating retired quota view aliases Signed-off-by: LoopX Agent <[email protected]> * fix: pin deferred native context reads to the original capture Signed-off-by: LoopX Agent <[email protected]> * Keep native capture navigation within small output budgets Signed-off-by: LoopX Agent <[email protected]> * Retire legacy heartbeat work prompt generation Signed-off-by: LoopX Agent <[email protected]> * Capture C1 composition failures as receipt diagnostics Signed-off-by: LoopX Agent <[email protected]> * Recover interrupted native Todo readiness from the original Turn Signed-off-by: LoopX Agent <[email protected]> * Revalidate the original lease before publishing resumed native context Signed-off-by: LoopX Agent <[email protected]> * Fence native readiness publication with the canonical lease writer Signed-off-by: LoopX Agent <[email protected]> * fix(scheduler): keep Codex fallback on the original C1 runtime Signed-off-by: LoopX Agent <[email protected]> * fix(scheduler): pin the originating fallback launchers Signed-off-by: LoopX Agent <[email protected]> * Retire the duplicate Codex App scheduler projection Signed-off-by: LoopX Agent <[email protected]> * Seed the recorded scheduler profile in the elapsed-backoff fixture Signed-off-by: LoopX Agent <[email protected]> * Verify canonical cadence on refused and settled Turns Signed-off-by: LoopX Agent <[email protected]> * Pin named Core commands in saved scheduler fallbacks Signed-off-by: LoopX Agent <[email protected]> * fix(research): preserve saved case addresses when a version cannot open Signed-off-by: LoopX Agent <[email protected]> * Preserve citation focus after a saved study refresh Signed-off-by: LoopX Agent <[email protected]> * Capture authenticated LoopX receipts for Research attention (#8790) * feat(research): capture authenticated LoopX attention receipts Signed-off-by: lusendong.6789 <[email protected]> Co-authored-by: TRAE CLI <[email protected]> * fix(research): tighten attention receipt provenance Signed-off-by: lusendong.6789 <[email protected]> Co-authored-by: TRAE CLI <[email protected]> * fix(research): publish attention captures after source validation Signed-off-by: huangruiteng <[email protected]> --------- Signed-off-by: lusendong.6789 <[email protected]> Signed-off-by: huangruiteng <[email protected]> Co-authored-by: TRAE CLI <[email protected]> Co-authored-by: huangruiteng <[email protected]> * Recover the original Session and Turn from a confirmed Chat task Signed-off-by: huangruiteng <[email protected]> * perf(lark,native_chat): eliminate redundant full-directory JSON reparsing in steward chat loops (#9041) * perf(lark,native_chat): avoid full directory reparsing in steward chat loops - Make LarkOwnerAttention._route iterate capture candidates lazily so matching stops at the newest valid p2p capture. - Reuse FileChatDiscovery in PrivateIngressObserver._records while preserving strict field validation and fail-closed errors. - Reuse FileChatDiscovery in ChatExternalConversations.pending so unchanged request journals skip redundant JSON reads and stay mutation-isolated. - Add regression and scan-efficiency tests in tests/test_lark_steward_directory_scan_perf.py. Signed-off-by: LoopX Agent <[email protected]> * fix(native-chat): project small recovery metadata fields to stop data_url memory growth Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * Retire transitional smoke checks and duplicate execution (#9073) Signed-off-by: lusendong.6789 <[email protected]> Co-authored-by: TRAE CLI <[email protected]> * feat(steward): support probe-gated generic continuous_monitor todos with handoff and user actions (#9074) Signed-off-by: LoopX Agent <[email protected]> * Remove redundant defensive prose from prompts and comments (#9072) Remove redundant defensive prose while preserving published heartbeat wrappers and externally managed skill readiness. Validated with 197 related tests, independent historical wrapper migrations and negative cases, installed-skill readback, and current-main quick canary. Existing CI qualification and infrastructure limitations remain recorded in PR #9072. Signed-off-by: lusendong.6789 <[email protected]> Signed-off-by: Lusen Dong <[email protected]> * Keep original Chat retry errors visible during receipt refresh Signed-off-by: LoopX Agent <[email protected]> * fix(steward): tolerate report validator python drift and allow cancel of mid-turn failed reports (#9077) Signed-off-by: LoopX Agent <[email protected]> * feat(steward): add exact-head PR review signals and protected merge confirmation (#9081) Signed-off-by: LoopX Agent <[email protected]> * feat(steward): add isolated OpenViking long-term memory with per-speaker boundaries (#9083) Signed-off-by: LoopX Agent <[email protected]> * refactor(content-ops): slim surface module and eliminate Any (#8961) * refactor(content-ops): slim surface module and eliminate Any Signed-off-by: LoopX Agent <[email protected]> * fix(content-ops): reject malformed angle source_item_ids containers Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(collaboration): batch handoff query Goal lifetime guard lock per Goal (#9085) Signed-off-by: LoopX Agent <[email protected]> * fix(hosts): raise managed service startup readiness timeout to 45s (#9087) Signed-off-by: LoopX Agent <[email protected]> * perf(manager-context): memoize history_inspect lifecycle checks and scope runtime revision in handoffs query (#9088) Eliminate the remaining O(N) Effect runtime RPCs and uncached runtime fingerprinting inside tracking.query(): enter effect_runtime_request_scope() for the query, memoize pure history_inspect lifecycle decisions across entries sharing identical Goal refs while holding the Goal lifetime guard, lazily discover legacy ingress files only when external audience recovery needs them, and preserve entry scan order across Goal batches. Signed-off-by: LoopX Agent <[email protected]> * refactor(lark): slim private_conversations below 2000 lines with net LOC reduction (#8929) Signed-off-by: LoopX Agent <[email protected]> * perf(chat,hosts): skip frontend source re-hashing on immutable installed releases and extend readiness timeout to 90s (#9089) Signed-off-by: LoopX Agent <[email protected]> * refactor(control-plane): split and slim quota monitor_poll_commit (#8885) * refactor(control-plane): split and slim quota monitor_poll_commit Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): preserve legacy lane budget and observation diagnostic order Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * refactor(quota): slim loopx/quota.py and tighten Any count to zero (#8939) Signed-off-by: LoopX Agent <[email protected]> * refactor(native-chat): slim external_conversations below 2k lines and retire ceiling (#8911) * refactor(native-chat): move steward commission mixin to steward_commands and retire external_conversations ceiling Signed-off-by: LoopX Agent <[email protected]> * fix(native-chat): respect include_raw_response in retained result recovery Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * refactor(chat): slim chat_runtime below 1,500 lines, fix entry-point project_contexts guard, and retire ceiling (#8920) * refactor(chat): move session lifecycle mixin to session_open, deduplicate runtime helpers, and retire ceiling Signed-off-by: LoopX Agent <[email protected]> * fix(chat): drop turn_done_events slot before waking waiters on Thread.start failure Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(steward): paginate open PR signal GraphQL, allow signal-unavailable monitor recovery, and cache private delivery scans (#9093) Signed-off-by: LoopX Agent <[email protected]> * perf(lark,native_chat): back off noop recovery retries and cache recovery lookups (#9096) Signed-off-by: LoopX Agent <[email protected]> * perf(native_chat,lark): cache unchanged quota backlog health and interrupt observations (#9098) Signed-off-by: LoopX Agent <[email protected]> * perf(lark,native_chat): coalesce listener snapshots and cache recovery event summaries (#9100) Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: cicolord <[email protected]> Signed-off-by: LoopX Agent <[email protected]> Signed-off-by: huangruiteng <[email protected]> Signed-off-by: lusendong.6789 <[email protected]> Signed-off-by: Lusen Dong <[email protected]> Co-authored-by: cicolord <[email protected]> Co-authored-by: huangruiteng <[email protected]> Co-authored-by: Lusen Dong <[email protected]> Co-authored-by: TRAE CLI <[email protected]> * refactor(issue-fix): consolidate maintainer-correction admission and slim pr_lifecycle (#8897) Signed-off-by: LoopX Agent <[email protected]> * Fix truncated requests and responses in the Codex API relay (#8713) * fix(codex relay): fence incomplete model requests before drain Signed-off-by: LoopX Agent <[email protected]> * fix(codex relay): surface incomplete upstream responses Port the verified response framing fix to the request-admission branch. Original candidate 27bc3aee311cdfc6a00466ff9d3b58c7db36e01b. Signed-off-by: LoopX Agent <[email protected]> * Bound Codex relay writes to clients that stop reading Signed-off-by: LoopX Agent <[email protected]> * Reject upstream chunked responses missing the trailer terminator Signed-off-by: LoopX Agent <[email protected]> * Validate upstream chunk data delimiters before relay completion Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(release): repair dsh closeout test, antigravity failover alias, and release download retry (#9147) Signed-off-by: LoopX Agent <[email protected]> * docs(release): update v2.4.0 release notes and dsh-loopx-plugin 0.1.1-beta.7 README (#9149) Signed-off-by: LoopX Agent <[email protected]> * fix(chat): recover saved answers and diagnose lost workers (#9120) * fix(chat): recover saved answers and diagnose lost workers Signed-off-by: LoopX Agent <[email protected]> * style(lark): keep private_conversations within module line budget Signed-off-by: LoopX Agent <[email protected]> * fix(chat): retain execution_worker_exited in pending backlog count Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(chat): resume steward requests lost before dispatch (#9125) Signed-off-by: LoopX Agent <[email protected]> * fix(benchmark): restore frozen v1 archives and align checkpoint/runtime tests with C1 defaults (#9151) Signed-off-by: LoopX Agent <[email protected]> * fix(release): stabilize CLI help, architecture guards, onboarding gate, and public smokes (#9152) Signed-off-by: LoopX Agent <[email protected]> * fix(steward): recover report selection across python upgrades and prevent queue kill on observation monitors (#9155) Signed-off-by: LoopX Agent <[email protected]> * fix(release): align extensions, chat, presentation, and transport tests for v2.4.0 (#9156) Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): stabilize v2.4.0 quota, turn-envelope, and capabilities slice (Slice B1) (#9154) * fix(control-plane): stabilize v2.4.0 quota, turn-envelope, and capabilities slice Signed-off-by: LoopX Agent <[email protected]> * fix(quota): preserve tokenless identity and exact numeric types in attach_complete_turn_context Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(steward): recover frozen report contract failures and rebind resumed task leases (#9157) Signed-off-by: LoopX Agent <[email protected]> * fix(steward): recover pre-dispatch runtime failures across endpoints and stop receipt-unknown disk churn (#9159) Signed-off-by: LoopX Agent <[email protected]> * fix(control_plane): align lease recovery, settlement readback, and runtime fixtures (#9158) * fix(control_plane): align lease recovery, settlement readback, and runtime fixtures Signed-off-by: LoopX Agent <[email protected]> * fix(control_plane): forward record_capture in worker outage test and harden version type guard Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): stabilize v2.4.0 explore, context, and checkpoint tail slice (Slice B4) (#9161) Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): stabilize v2.4.0 replan, monitor recovery, and staged-read slice (Slice B5) (#9160) Signed-off-by: LoopX Agent <[email protected]> * docs(release): reconcile final v2.4.0 stabilization PRs and boundary wording (#9162) * docs(release): reconcile final v2.4.0 stabilization PRs and boundary wording Signed-off-by: LoopX Agent <[email protected]> * docs(release): align #9158 and #9161 descriptions with verified commits Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> * fix(steward): tolerate minor JSON delimiter glitches and recover saved report candidates (#9164) Signed-off-by: LoopX Agent <[email protected]> * fix(control-plane): preserve bound yardstick reversals in native replan openings (#9165) Signed-off-by: LoopX Agent <[email protected]> * fix(native-chat): recover loopback relay 401 failures and isolate test auth (#9167) Signed-off-by: LoopX Agent <[email protected]> --------- Signed-off-by: LoopX Agent <[email protected]> Signed-off-by: cicolord <[email protected]> Signed-off-by: huangruiteng <[email protected]> Signed-off-by: lusendong.6789 <[email protected]> Signed-off-by: Lusen Dong <[email protected]> Co-authored-by: cicolord <[email protected]> Co-authored-by: huangruiteng <[email protected]> Co-authored-by: Lusen Dong <[email protected]> Co-authored-by: TRAE CLI <[email protected]>
Delivery Brief
admitReportSelectionRecovery,admitReportQuotaRecovery,admitStewardManagedTurnlaunch recovery) checked strict equality onvalidation_command, rejecting legitimate Python executable path updates across local release upgrades even though Python's_same_report_validator_commandtolerated them;_prepare_submissionalso preserved oldvalidation_commandpaths in quota-recovery requests._drain_session_queue_eventscalledcontroller._ensure_adapter()while an active observation-only monitor (work_kind == 'monitor'onStewardObservationAdapter) was running or crash-queued, failing no-model monitor turns withruntime_unavailable. And once a.restart-recoverymonitor carrier failed transiently post-context, it remained wedged forever under a one-shot retry check.loopx/control_plane/collaboration/steward_managed_mode.ts: AddsameReportValidatorCommand/sameReportRequestField/sameReportRequestacross report selection, quota, and launch recovery while still rejecting target/flag drift. Allow chained recovery of post-context zero-effect monitor carriers (runtime_unavailable, signal outage, disk I/O, worker exit) only after a 300s cooldown (MONITOR_RECOVERY_RETRY_COOLDOWN_MS), while keepingscopeRefusedandidentityRefusedstrictly one-shot.loopx/capabilities/native_chat/steward_turn.py: Refreshvalidation_command[0]in quota recovery requests via_same_report_validator_command, emitobserved_atinmonitor_restart_basis, and apply the matching 300s cooldown inmonitor_restart_request.loopx/capabilities/native_chat/session_queue.py: Add_is_observation_only_monitor_turnso queue draining neither prepares model adapters nor fails active/queued observation-only monitor turns when model transports are unavailable.node --experimental-strip-types --test tests/control_plane_ts/steward_managed_mode.test.ts tests/control_plane_ts/steward_reports.test.ts(26/26 passed)uv run --extra test ruff check(passed)uv run --extra test python -m pytest tests/test_steward_report_recovery_and_validator.py tests/test_native_steward_monitor.py(5/5 and 176/176 passed) +tests/test_chat_queue_preparation.py(43+1 passed)uv run --extra test loopx canary premerge --from-git-diff --git-diff-base origin/main --tier quick(passed,failures=0)